Skip to content

Add DBUS_SESSION_BUS_ADDRESS to env_keep (Fixes #358) #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add DBUS_SESSION_BUS_ADDRESS to env_keep (Fixes #358) #381

wants to merge 1 commit into from

Conversation

a-k-g
Copy link
Contributor

@a-k-g a-k-g commented Feb 6, 2017

@hnryjms
Copy link
Contributor

hnryjms commented Feb 8, 2017

What if we change the ENV line in the Dockerfile for Chrome to instead write the variable to Ubuntu's /etc/environment path? I haven't tried this in the Selenium docker machine to confirm it fixes the issue, but when running a simple ubuntu:16.04 box (the origin of Selenium base), this diff adds environment variable changes when running sudo -E -i -u [username] env as well as regular env

USER seluser
# Following line fixes
# https://github.com/SeleniumHQ/docker-selenium/issues/87
- ENV DBUS_SESSION_BUS_ADDRESS=/dev/null
+ RUN echo "DBUS_SESSION_BUS_ADDRESS=/dev/null" >> /etc/environment

@a-k-g
Copy link
Contributor Author

a-k-g commented Feb 9, 2017

That should do it as well. I don't have a preference for either approach. I can update the PR if that's a more desirable approach.

@ddavison
Copy link
Member

ddavison commented Feb 9, 2017

is this succeeded by #386 ? can we close this one in favor of that?

@a-k-g
Copy link
Contributor Author

a-k-g commented Feb 9, 2017

Yeah, sure.

@a-k-g a-k-g closed this Feb 9, 2017
@a-k-g a-k-g deleted the fix-dbus-env branch February 9, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants