Skip to content

Set proper GRID_TIMEOUT #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2017
Merged

Set proper GRID_TIMEOUT #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb4ca24
Set proper GRID TIMEOUT value
wheleph Feb 16, 2017
58568ee
Add comment about time units used in environment variables
wheleph Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Hub/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ENV GRID_NEW_SESSION_WAIT_TIMEOUT -1
ENV GRID_JETTY_MAX_THREADS -1
ENV GRID_NODE_POLLING 5000
ENV GRID_CLEAN_UP_CYCLE 5000
ENV GRID_TIMEOUT 30000
ENV GRID_TIMEOUT 30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too low, now I have to implement an override

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok :) that's how they're meant to be used. since this is an environment variable passed to the container, you can set it to whatever you need it to be. it would be hard for this default value to match "everybody's" standards.

ENV GRID_BROWSER_TIMEOUT 0
ENV GRID_MAX_SESSION 5
ENV GRID_UNREGISTER_IF_STILL_DOWN_AFTER 30000
Expand Down
8 changes: 7 additions & 1 deletion Hub/Dockerfile.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,19 @@ MAINTAINER Selenium <[email protected]>
EXPOSE 4444

ENV GRID_THROW_ON_CAPABILITY_NOT_PRESENT true
# In milliseconds
ENV GRID_NEW_SESSION_WAIT_TIMEOUT -1
ENV GRID_JETTY_MAX_THREADS -1
# In milliseconds
ENV GRID_NODE_POLLING 5000
# In milliseconds
ENV GRID_CLEAN_UP_CYCLE 5000
ENV GRID_TIMEOUT 30000
# In seconds
ENV GRID_TIMEOUT 30
# In seconds
ENV GRID_BROWSER_TIMEOUT 0
ENV GRID_MAX_SESSION 5
# In milliseconds
ENV GRID_UNREGISTER_IF_STILL_DOWN_AFTER 30000

COPY generate_config /opt/selenium/generate_config
Expand Down
2 changes: 1 addition & 1 deletion Hub/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Note: You can optionally override default configuration settings using environme
See the [Hub's Dockerfile](Dockerfile) to view the list of variables and their default values.

```
$ docker run -d -P --name selenium-hub -e GRID_TIMEOUT=10000 selenium/hub
$ docker run -d -P --name selenium-hub -e GRID_TIMEOUT=10 selenium/hub
```


Expand Down