Fix work with environment variables at xvfb-run (2nd time)
#459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@ddavison, maybe we can enable this setting in the repo to avoid having these type of issues with PRs? (Getting stuff overwritten).
|
|
done :) |
This was referenced Apr 22, 2017
|
👍 |
This was referenced Apr 23, 2017
This was referenced May 2, 2017
NiGhTTraX
added a commit
to NiGhTTraX/react-test-buffet
that referenced
this pull request
May 5, 2017
Need the fix in SeleniumHQ/docker-selenium#459 to enable debug logs for the debug nodes. The new screenshots are due to an updated Chrome version in the images.
randytsmith
pushed a commit
to randytsmith/javascript_testing
that referenced
this pull request
Apr 1, 2018
Need the fix in SeleniumHQ/docker-selenium#459 to enable debug logs for the debug nodes. The new screenshots are due to an updated Chrome version in the images.
dezine2dev
added a commit
to dezine2dev/Javascript-testing
that referenced
this pull request
Jul 4, 2018
Need the fix in SeleniumHQ/docker-selenium#459 to enable debug logs for the debug nodes. The new screenshots are due to an updated Chrome version in the images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just making the same change @metajiji did in #445 which fixes #423, but got overwritten in #455, therefore the current release 3.3.1-cesium brought that bug back. I'm just adding the same change for the Firefox Debug image and the Standalone images.
Tested it locally by building the images and using the docker-compose file provided in #423, the change done by @metajiji works.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement