-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Config generation at runtime + buildtime #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
# IMPORTANT: Change this file only in directory NodeDebug! | ||
|
||
source /opt/bin/functions.sh | ||
/opt/bin/generate_config > /opt/selenium/config.json | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would these lines replace the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think they should both exist. This is actually done for the hub : Hub/Dockerfile#L39 & Hub/entry_point.sh#L6 |
||
|
||
export GEOMETRY="$SCREEN_WIDTH""x""$SCREEN_HEIGHT""x""$SCREEN_DEPTH" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NodeBase
doesn't have agenerate_config
this would fail, no?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the commit 0dd193a (Moving config generation in docker files) the line was here.
I believe that it's because NodeBase is not runned directly, it's used in other images that have generate_config.
For instance for Chrome.
In NodeBase Dockerfile.txt, the entry point is set :
It calls
entry_point.sh
which calls forgenerate_config
.In NodeChrome Dockerfile.txt, the
generate_config
file is copyied inside the image, before the entrypoint is called :So when the image is launched, the entrypoint is called, and it can generate the config because generate_config is in the image.