Skip to content

Use latest chromedriver version by default #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Use latest chromedriver version by default #545

merged 1 commit into from
Sep 6, 2017

Conversation

glibas
Copy link

@glibas glibas commented Aug 31, 2017

Use latest chromedriver version, since latest stable Chrome version is used by default.
CHROME_DRIVER_VERSION still can be overridden when building the image.

@ddavison
Copy link
Member

i like the idea, and a good implementation!

I think i'll wait to merge this with advice from the community / team though, since there are potential drawbacks to something like this.

As with any dependency, you shouldn't always fetch latest because of compatibility issues. I'd hate to run into an issue where people are downloading 3.5.1 (later in the future) and they can't run it without building their own containers because the version is fetching latest.

There's always potential drawbacks to doing something like this.

On the other hand, we already do this for things like google-chrome. we use an apt-get -qqy install \ ${CHROME_VERSION:-google-chrome-stable} which basically does the same thing.

@glibas
Copy link
Author

glibas commented Aug 31, 2017

Hi @ddavison ,

Thank you for the feedback. Yes, as you have said the 'latest' approach is already used for Chrome and since its tightly coupled with chromedriver its either use 'latest' for both or manually simultaneously update versions for both imho.

Surely better to discuss wit community first.

Thanks

@hazmeister
Copy link
Contributor

Looks like a sensible default, it's still possible to override with a specific version if you need it.

@ddavison ddavison merged commit b2f3abc into SeleniumHQ:master Sep 6, 2017
@ddavison
Copy link
Member

ddavison commented Sep 6, 2017

thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants