Add Chinese fonts for #339 #367 #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Chinese fonts ttf-wqy-microhei and ttf-wqy-zenhei
lcnja
changed the title
|
|
|
Hi @omz-one, Thanks for this PR! Did you check how much bigger the image gets? |
|
Hi @omz-one, Could you check my comment? In addition, why is the change made on the Base dockerfile? Shouldn't it be done on the NodeBase dockerfile? |
|
OK, so the images grow around ~25MB, which is ok I think, considering that a bigger user base will be able to render websites that use this character set. We'll merge it but then move the two fonts to the NodeBase dockerfile. |
|
Before: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chinese fonts ttf-wqy-microhei and ttf-wqy-zenhei
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement