Update README.md #724
Merged
Update README.md #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just incase users are using docker-compose version 3; delineated between version 2 and 3
|
this is a nice doc update! have you made sure that this docker compose works? |
|
I've answered my own question - it "does" work. one more requested change, @MacCracken - could you add the |
|
@MacCracken please reference the variables |
I've updated to comments to read for yaml, changing variables HUB_HOST and HUB_PORT haven't been tested by me on my side. I can confirm these settings work.
updated the variables - had to test they didn't break the dockers
|
Looks good, thanks @MacCracken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just incase users are using docker-compose version 3; delineated between version 2 and 3
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement