Find free xvfb display instead of hardcoded 99 using the -a option #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diemol
requested changes
Aug 30, 2018
|
Thanks @anto-ac! I added some comments to it. |
Up until now the xvfb display has been hardcoded to 99 for all nodes. This sometimes causes errors if the display is not actually free. xvfb-run has a -a --auto-servernum option, which tries to get a free server number, starting at 99, or the argument to --server-num. Fixes #772
diemol
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now the xvfb display has been hardcoded to 99 for all nodes.
This sometimes causes errors if the display is not actually free.
xvfb-run has a -a --auto-servernum option, which tries to get a free
server number, starting at 99, or the argument to --server-num.
Fixes #772
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement