Skip to content

README improvements and fixes #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2018
Merged

README improvements and fixes #803

merged 4 commits into from
Oct 6, 2018

Conversation

elemenophy
Copy link

Issue #799 was partially caused by a missing port in the docker run
statement

Ayoze and others added 2 commits October 5, 2018 08:25
Issue #799 was partially caused by a missing port in the docker run
statement
@elemenophy elemenophy changed the title Missing docker port in REMOTE_HOST example. Documentation improvements and fixes Oct 5, 2018
@elemenophy elemenophy changed the title Documentation improvements and fixes README improvements and fixes Oct 5, 2018
@elemenophy
Copy link
Author

FYI, CI is failing due to an unrelated error.

@diemol
Copy link
Member

diemol commented Oct 6, 2018

Hi @ay0o,

Thanks for the PR. Could you also please add instructions showing to to start Docker Swarm?

@elemenophy
Copy link
Author

@diemol updated it, but I think that's out of the scope of docker-selenium.

@diemol
Copy link
Member

diemol commented Oct 6, 2018

Thanks for your contribution!

@diemol diemol merged commit 71657be into SeleniumHQ:master Oct 6, 2018
@elemenophy elemenophy deleted the fix_readme branch October 6, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants