-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[rb] Add support for beta chrome #15874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
🔗 Related Issues
This PR introduces the changes that were originally supposed to be introduced in #15417 and reverted in #15837
💥 What does this PR do?
This PR adds beta Chrome support for the Ruby pipeline
🔧 Implementation Notes
The changes implemented introduced the download of the beta Chrome in pinned browsers and added it to the integration tests
💡 Additional Considerations
We started seeing memory heap issues, but that is due to Bazel and not this PR
PR Type
Enhancement
Description
Add beta Chrome support to Ruby pipeline
Update integration tests to run with beta Chrome
Refactor and generalize Chrome pinning logic in scripts
Update browser and driver versions for Edge and Firefox
Changes walkthrough 📝
4 files
Add beta Chrome and Chromedriver data targets
Add beta Chrome/Chromedriver repos, update browser versions
Add chrome-beta browser config for Ruby tests
Refactor and add beta Chrome/Chromedriver pinning logic
1 files
Register beta Chrome/Chromedriver in Bazel module
2 files
Add chrome-beta to integration test browsers list
Run Chrome integration tests with chrome-beta