[py] do not use global var for devtools, allows multiple devtools to run

[Delta456]

User description

🔗 Related Issues

💥 What does this PR do?

Fixes #15816

🔧 Implementation Notes

Removes global devtools entirely and use devtool member in WebDriver for whatever use

💡 Additional Considerations

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Bug fix, Tests

---

Description

• Refactored devtools from global to WebDriver instance member

• Fixed bug allowing multiple devtools sessions per driver

• Added test for starting devtools on multiple drivers

---

Changes walkthrough 📝

	Relevant files
Bug fix	webdriver.py Refactor devtools to instance member and fix multi-driver support py/selenium/webdriver/remote/webdriver.py Removed global devtools variable and logic Made devtools an instance member (_devtools) of WebDriver Refactored start_devtools to use instance member and support multiple drivers Improved error handling and code clarity in devtools startup Minor docstring formatting improvements +26/-31
Tests	devtools_tests.py Add test for multiple devtools sessions per driver              py/test/selenium/webdriver/common/devtools_tests.py Added test to verify start_devtools works on multiple drivers Ensured test covers regression for global devtools bug +13/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 15816 - Fully compliant Compliant requirements: • Fix bug where calling start_devtools() in 2 different drivers doesn't work • Resolve "local variable 'ws_url' referenced before assignment" error • Remove global devtools variable that outlives individual WebDrivers • Make devtools a WebDriver instance member instead of global • Allow multiple devtools sessions to work properly

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Logic Flow The refactored start_devtools method has complex conditional logic that should be verified for all execution paths, especially the early return condition and websocket connection reuse. def start_devtools(self): global cdp import_cdp() if self.caps.get("se:cdp"): ws_url = self.caps.get("se:cdp") version = self.caps.get("se:cdpVersion").split(".")[0] else: version, ws_url = self._get_cdp_details() if not ws_url: raise WebDriverException("Unable to find url to connect to from capabilities") self._devtools = cdp.import_devtools(version) if self._websocket_connection: return self._devtools, self._websocket_connection if self.caps["browserName"].lower() == "firefox": raise RuntimeError("CDP support for Firefox has been removed. Please switch to WebDriver BiDi.") self._websocket_connection = WebSocketConnection(ws_url) targets = self._websocket_connection.execute(self._devtools.target.get_targets()) target_id = targets[0].target_id session = self._websocket_connection.execute(self._devtools.target.attach_to_target(target_id, True)) self._websocket_connection.session_id = session return self._devtools, self._websocket_connection Test Coverage The new test only verifies that start_devtools can be called on multiple drivers sequentially, but doesn't test concurrent usage or verify that each driver gets its own devtools instance. def test_check_start_twice(clean_driver, clean_options, clean_service): driver1 = clean_driver(options=clean_options, service=clean_service) devtools1, connection1 = driver1.start_devtools() driver1.quit() driver2 = clean_driver(options=clean_options, service=clean_service) devtools2, connection2 = driver2.start_devtools() driver2.quit()

[qodo-merge-pro]

PR Code Suggestions ✨

No code suggestions found for the PR.

[cgoldberg]

nice work. Thanks for fixing this.

[navin772]

@Delta456 The tests fail because the clean_driver fixture does not follows the xfail rules as the driver fixture does and launches test against firefox even if we mention xfail.
You will need to modify the clean_driver fixture in conftest.py to include the xfail logic similar to this:

selenium/py/conftest.py

Lines 327 to 337 in cc3ea7b

	# conditionally mark tests as expected to fail based on driver
	marker = request.node.get_closest_marker(f"xfail_{driver_class.lower()}")
	if marker is not None:
	if "run" in marker.kwargs:
	if marker.kwargs["run"] is False:
	pytest.skip()
	yield
	return
	if "raises" in marker.kwargs:
	marker.kwargs.pop("raises")
	pytest.xfail(**marker.kwargs)

[navin772]

LGTM!

[cgoldberg]

@Delta456 looks good to merge. Let me know if you don't have access and I'll merge it.

[Delta456]

@Delta456 looks good to merge. Let me know if you don't have access and I'll merge it.

I now have access. I will merge it in few hours :)