-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Innazh/add browser options examples java #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Innazh/add browser options examples java #1865
Conversation
added java examples/tests for browserName, browserVersion,platformName, scriptTimeout, pageLoadTimeout, implicitWaitTimeout, unhandledPromptBehaviour, setWindowRect, strictFileInteractability
added all mising examples for java for driver options page, except for the ones that require moving code
based on the changes I just made to the example file
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
I was using toString() on a string variable by accident, removing it here.
using assertions library, fixed spacing to match the rest of the code, added the missing imports. All of this threw off the line numbers for the options docs, so will have to edit it in the next commit.
Since I had added imports, the line numbers fro the examples had to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @innazh!
User description
Add missing Driver Options examples for Java & incorporate those into the docs
Description
Motivation and Context
The examples were missing in the docs, I'm replacing the "Add example" badges.
Types of changes
Checklist
PR Type
Tests, Documentation
Description
OptionsTest.java
.Changes walkthrough 📝
OptionsTest.java
Add Java test examples for ChromeOptions settings
examples/java/src/test/java/dev/selenium/drivers/OptionsTest.java
capabilities.
options.en.md
Update Java examples in English documentation
website_and_docs/content/documentation/webdriver/drivers/options.en.md
options.ja.md
Update Java examples in Japanese documentation
website_and_docs/content/documentation/webdriver/drivers/options.ja.md
options.pt-br.md
Update Java examples in Portuguese documentation
website_and_docs/content/documentation/webdriver/drivers/options.pt-br.md
options.zh-cn.md
Update Java examples in Chinese documentation
website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md