Skip to content

Themed favicon with transparent background #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 9, 2024

User description

Description

This is favicon which looks good in dark/white mode, because of the background is transparent.

Motivation and Context

I use dark mode, and it would be great if selenium icon looks great in browser tab.

It should replace it:
image

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement


Description

  • Updated the favicon to have a transparent background for better appearance in both dark and light modes.
  • Ensures the Selenium icon looks aesthetically pleasing in browser tabs, especially for users in dark mode.

Changes walkthrough 📝

Relevant files

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

netlify bot commented Sep 9, 2024

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 76909b6

@qodo-merge-pro qodo-merge-pro bot added the enhancement New feature or request label Sep 9, 2024
Copy link
Contributor

qodo-merge-pro bot commented Sep 9, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nvborisenko !

@harsha509 harsha509 merged commit 8ae22e2 into SeleniumHQ:trunk Sep 9, 2024
3 checks passed
@nvborisenko nvborisenko mentioned this pull request Sep 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants