Skip to content

Add release notes for docker-selenium 4.25.0 #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Sep 23, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Added detailed release notes for Docker Selenium 4.25.0, highlighting key enhancements and fixes.
  • Enhanced KEDA scaler behavior in Kubernetes, addressing platform-specific scaling issues and excessive autoscaling.
  • Introduced new parameters for basic authentication and session control in the Grid GraphQL endpoint.
  • Updated Selenium Grid Helm Chart to support new KEDA scaler enhancements.

Changes walkthrough 📝

Relevant files
Documentation
selenium-4-25-released.md
Add release notes for Docker Selenium 4.25.0                         

website_and_docs/content/blog/2024/selenium-4-25-released.md

  • Added release notes for Docker Selenium 4.25.0.
  • Enhanced KEDA scaler behavior in Kubernetes.
  • Introduced new parameters for basic authentication and session
    control.
  • Updated Selenium Grid Helm Chart for KEDA scaler enhancements.
  • +13/-0   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Sep 23, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit bd9f12f

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 2 labels Sep 23, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Include information about potential upgrade considerations for the KEDA scaler changes

    Consider adding a brief mention of any potential breaking changes or migration steps
    required for users upgrading to this version, especially regarding the KEDA scaler
    enhancements.

    website_and_docs/content/blog/2024/selenium-4-25-released.md [71-74]

     - KEDA Scaler in Kubernetes:
       - Enhanced KEDA scaler behavior, addressing:
         - Node with different platformName scaling: Fixed incorrect scaling behavior when both Linux and Windows node stereotypes are present ([#1925](https://github.com/SeleniumHQ/docker-selenium/issues/1925)).
         - Excessive autoscaling: Resolved over-scaling of browser nodes ([#2160](https://github.com/SeleniumHQ/docker-selenium/issues/2160)).
    +  - Note: Users upgrading from previous versions should review their KEDA configurations to ensure compatibility with these enhancements.
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Mentioning potential breaking changes or migration steps is important for users to ensure a smooth upgrade process, especially when significant enhancements like KEDA scaler changes are involved.

    9
    Enhancement
    Elaborate on the purpose and benefits of the new session control parameter

    Provide more context on the impact of the nodeMaxSessions parameter. Explain how it
    affects performance or resource utilization to help users understand when and why
    they might want to use this feature.

    website_and_docs/content/blog/2024/selenium-4-25-released.md [76]

    -- Added support for `nodeMaxSessions` parameter to control maximum concurrent sessions per node, aligning with the node config `--max-sessions` ([#2402](https://github.com/SeleniumHQ/docker-selenium/pull/2402)).
    +- Added support for `nodeMaxSessions` parameter to control maximum concurrent sessions per node, aligning with the node config `--max-sessions` ([#2402](https://github.com/SeleniumHQ/docker-selenium/pull/2402)). This allows fine-tuning of resource allocation and can help optimize performance in high-load scenarios.
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Providing additional context on the nodeMaxSessions parameter helps users understand its impact on performance and resource utilization, which is valuable for making informed decisions about its use.

    8
    Add a usage example for the new basic authentication parameters

    Consider adding a brief explanation or example of how to use the new username and
    password parameters for basic authentication. This would provide immediate value to
    users looking to implement this feature.

    website_and_docs/content/blog/2024/selenium-4-25-released.md [75]

    -- Added separate parameters for basic authentication (`username`, `password`) for the Grid GraphQL endpoint ([#2401](https://github.com/SeleniumHQ/docker-selenium/pull/2401)).
    +- Added separate parameters for basic authentication (`username`, `password`) for the Grid GraphQL endpoint ([#2401](https://github.com/SeleniumHQ/docker-selenium/pull/2401)). For example: `--username myuser --password mypass`.
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion provides a practical example for using the new parameters, which can help users quickly understand how to implement the feature. However, it is not crucial for understanding the release notes.

    7

    💡 Need additional feedback ? start a PR chat

    @diemol diemol merged commit 6403430 into SeleniumHQ:trunk Sep 23, 2024
    3 checks passed
    selenium-ci added a commit that referenced this pull request Sep 23, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants