You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
Include information about potential upgrade considerations for the KEDA scaler changes
Consider adding a brief mention of any potential breaking changes or migration steps required for users upgrading to this version, especially regarding the KEDA scaler enhancements.
- KEDA Scaler in Kubernetes:
- Enhanced KEDA scaler behavior, addressing:
- Node with different platformName scaling: Fixed incorrect scaling behavior when both Linux and Windows node stereotypes are present ([#1925](https://github.com/SeleniumHQ/docker-selenium/issues/1925)).
- Excessive autoscaling: Resolved over-scaling of browser nodes ([#2160](https://github.com/SeleniumHQ/docker-selenium/issues/2160)).
+ - Note: Users upgrading from previous versions should review their KEDA configurations to ensure compatibility with these enhancements.
Apply this suggestion
Suggestion importance[1-10]: 9
Why: Mentioning potential breaking changes or migration steps is important for users to ensure a smooth upgrade process, especially when significant enhancements like KEDA scaler changes are involved.
9
Enhancement
Elaborate on the purpose and benefits of the new session control parameter
Provide more context on the impact of the nodeMaxSessions parameter. Explain how it affects performance or resource utilization to help users understand when and why they might want to use this feature.
-- Added support for `nodeMaxSessions` parameter to control maximum concurrent sessions per node, aligning with the node config `--max-sessions` ([#2402](https://github.com/SeleniumHQ/docker-selenium/pull/2402)).+- Added support for `nodeMaxSessions` parameter to control maximum concurrent sessions per node, aligning with the node config `--max-sessions` ([#2402](https://github.com/SeleniumHQ/docker-selenium/pull/2402)). This allows fine-tuning of resource allocation and can help optimize performance in high-load scenarios.
Apply this suggestion
Suggestion importance[1-10]: 8
Why: Providing additional context on the nodeMaxSessions parameter helps users understand its impact on performance and resource utilization, which is valuable for making informed decisions about its use.
8
Add a usage example for the new basic authentication parameters
Consider adding a brief explanation or example of how to use the new username and password parameters for basic authentication. This would provide immediate value to users looking to implement this feature.
-- Added separate parameters for basic authentication (`username`, `password`) for the Grid GraphQL endpoint ([#2401](https://github.com/SeleniumHQ/docker-selenium/pull/2401)).+- Added separate parameters for basic authentication (`username`, `password`) for the Grid GraphQL endpoint ([#2401](https://github.com/SeleniumHQ/docker-selenium/pull/2401)). For example: `--username myuser --password mypass`.
Apply this suggestion
Suggestion importance[1-10]: 7
Why: The suggestion provides a practical example for using the new parameters, which can help users quickly understand how to implement the feature. However, it is not crucial for understanding the release notes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
documentation
Description
Changes walkthrough 📝
selenium-4-25-released.md
Add release notes for Docker Selenium 4.25.0
website_and_docs/content/blog/2024/selenium-4-25-released.md
control.