Skip to content

chore(deps): update dependency rubocop-rspec to v3.1.0 #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 1, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop-rspec (changelog) 3.0.5 -> 3.1.0 age adoption passing confidence

Release Notes

rubocop/rubocop-rspec (rubocop-rspec)

v3.1.0

Compare Source

  • Add RSpec/StringAsInstanceDoubleConstant to check for and correct strings used as instance_doubles. ([@​corsonknowles])
  • Fix false-positive for RSpec/UnspecifiedException when a method is literally named raise_exception. ([@​aarestad])
  • Fix false-positive for RSpec/UnspecifiedException when not_to raise_error is used within a block. ([@​aarestad], [@​G-Rath])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit b8c06d6
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6709494fbfe5e30007ebac3d
😎 Deploy Preview https://deploy-preview-1978--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

qodo-merge-pro bot commented Oct 1, 2024

CI Failure Feedback 🧐

(Checks updated until commit b8c06d6)

Action: tests (macos, stable)

Failed stage: Run tests [❌]

Failed test name: Remote WebDriver starts remotely

Failure summary:

The action failed due to multiple errors in the Remote WebDriver tests. Specifically:

  • The test Remote WebDriver starts remotely failed with a TypeError indicating "no implicit conversion
    of String into Integer".
  • The test Remote WebDriver uploads also encountered the same TypeError.
  • The test Remote WebDriver downloads similarly failed with the TypeError.
  • These errors occurred in the file ./spec/drivers/remote_webdriver_spec.rb at lines 10, 16, and 17.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  macOS
    ...
    
    270:  timeout_minutes: 20
    271:  max_attempts: 3
    272:  command: cd examples/ruby
    273:  bundle exec rspec
    274:  
    275:  retry_wait_seconds: 10
    276:  polling_interval_seconds: 1
    277:  warning_on_retry: true
    278:  continue_on_error: false
    ...
    
    283:  PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools
    284:  JAVA_HOME: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.24-8/arm64/Contents/Home
    285:  JAVA_HOME_11_ARM64: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.24-8/arm64/Contents/Home
    286:  ##[endgroup]
    287:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    288:  Pending: (Failures listed here are expected and do not affect your suite's status)
    289:  1) Keys copy and paste
    290:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    291:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    410:  40) Element Locators with relative locators finds near element
    411:  # These are reference following the documentation example
    412:  # ./spec/elements/locators_spec.rb:55
    413:  41) Element Locators with relative locators chains relative locators
    414:  # These are reference following the documentation example
    415:  # ./spec/elements/locators_spec.rb:59
    416:  Failures:
    417:  1) Remote WebDriver starts remotely
    418:  Got 0 failures and 2 other errors:
    419:  1.1) Failure/Error:
    420:  Selenium::Server.get(:latest,
    421:  background: true,
    422:  args: %w[--selenium-manager true --enable-managed-downloads true])
    423:  TypeError:
    424:  no implicit conversion of String into Integer
    425:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    426:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    427:  1.2) Failure/Error:
    428:  Selenium::Server.get(:latest,
    429:  background: true,
    430:  args: %w[--selenium-manager true --enable-managed-downloads true])
    431:  TypeError:
    432:  no implicit conversion of String into Integer
    433:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    434:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    435:  2) Remote WebDriver uploads
    436:  Got 0 failures and 2 other errors:
    437:  2.1) Failure/Error:
    438:  Selenium::Server.get(:latest,
    439:  background: true,
    440:  args: %w[--selenium-manager true --enable-managed-downloads true])
    441:  TypeError:
    442:  no implicit conversion of String into Integer
    443:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    444:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    445:  2.2) Failure/Error:
    446:  Selenium::Server.get(:latest,
    447:  background: true,
    448:  args: %w[--selenium-manager true --enable-managed-downloads true])
    449:  TypeError:
    450:  no implicit conversion of String into Integer
    451:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    452:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    453:  3) Remote WebDriver downloads
    454:  Got 0 failures and 2 other errors:
    455:  3.1) Failure/Error:
    456:  Selenium::Server.get(:latest,
    457:  background: true,
    458:  args: %w[--selenium-manager true --enable-managed-downloads true])
    459:  TypeError:
    460:  no implicit conversion of String into Integer
    461:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    462:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    463:  3.2) Failure/Error:
    464:  Selenium::Server.get(:latest,
    465:  background: true,
    466:  args: %w[--selenium-manager true --enable-managed-downloads true])
    467:  TypeError:
    468:  no implicit conversion of String into Integer
    469:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    470:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    471:  Finished in 6 minutes 5 seconds (files took 7.67 seconds to load)
    472:  185 examples, 3 failures, 41 pending
    473:  Failed examples:
    474:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    475:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    476:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    477:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    478:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    479:  Pending: (Failures listed here are expected and do not affect your suite's status)
    480:  1) Keys copy and paste
    481:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    482:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    601:  40) Element Locators with relative locators finds near element
    602:  # These are reference following the documentation example
    603:  # ./spec/elements/locators_spec.rb:55
    604:  41) Element Locators with relative locators chains relative locators
    605:  # These are reference following the documentation example
    606:  # ./spec/elements/locators_spec.rb:59
    607:  Failures:
    608:  1) Remote WebDriver starts remotely
    609:  Got 0 failures and 2 other errors:
    610:  1.1) Failure/Error:
    611:  Selenium::Server.get(:latest,
    612:  background: true,
    613:  args: %w[--selenium-manager true --enable-managed-downloads true])
    614:  TypeError:
    615:  no implicit conversion of String into Integer
    616:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    617:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    618:  1.2) Failure/Error:
    619:  Selenium::Server.get(:latest,
    620:  background: true,
    621:  args: %w[--selenium-manager true --enable-managed-downloads true])
    622:  TypeError:
    623:  no implicit conversion of String into Integer
    624:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    625:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    626:  2) Remote WebDriver uploads
    627:  Got 0 failures and 2 other errors:
    628:  2.1) Failure/Error:
    629:  Selenium::Server.get(:latest,
    630:  background: true,
    631:  args: %w[--selenium-manager true --enable-managed-downloads true])
    632:  TypeError:
    633:  no implicit conversion of String into Integer
    634:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    635:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    636:  2.2) Failure/Error:
    637:  Selenium::Server.get(:latest,
    638:  background: true,
    639:  args: %w[--selenium-manager true --enable-managed-downloads true])
    640:  TypeError:
    641:  no implicit conversion of String into Integer
    642:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    643:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    644:  3) Remote WebDriver downloads
    645:  Got 0 failures and 2 other errors:
    646:  3.1) Failure/Error:
    647:  Selenium::Server.get(:latest,
    648:  background: true,
    649:  args: %w[--selenium-manager true --enable-managed-downloads true])
    650:  TypeError:
    651:  no implicit conversion of String into Integer
    652:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    653:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    654:  3.2) Failure/Error:
    655:  Selenium::Server.get(:latest,
    656:  background: true,
    657:  args: %w[--selenium-manager true --enable-managed-downloads true])
    658:  TypeError:
    659:  no implicit conversion of String into Integer
    660:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    661:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    662:  Finished in 7 minutes 25 seconds (files took 2.72 seconds to load)
    663:  185 examples, 3 failures, 41 pending
    664:  Failed examples:
    665:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    666:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    667:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    668:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    669:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    670:  Pending: (Failures listed here are expected and do not affect your suite's status)
    671:  1) Keys copy and paste
    672:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    673:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    792:  40) Element Locators with relative locators finds near element
    793:  # These are reference following the documentation example
    794:  # ./spec/elements/locators_spec.rb:55
    795:  41) Element Locators with relative locators chains relative locators
    796:  # These are reference following the documentation example
    797:  # ./spec/elements/locators_spec.rb:59
    798:  Failures:
    799:  1) Remote WebDriver starts remotely
    800:  Got 0 failures and 2 other errors:
    801:  1.1) Failure/Error:
    802:  Selenium::Server.get(:latest,
    803:  background: true,
    804:  args: %w[--selenium-manager true --enable-managed-downloads true])
    805:  TypeError:
    806:  no implicit conversion of String into Integer
    807:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    808:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    809:  1.2) Failure/Error:
    810:  Selenium::Server.get(:latest,
    811:  background: true,
    812:  args: %w[--selenium-manager true --enable-managed-downloads true])
    813:  TypeError:
    814:  no implicit conversion of String into Integer
    815:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    816:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    817:  2) Remote WebDriver uploads
    818:  Got 0 failures and 2 other errors:
    819:  2.1) Failure/Error:
    820:  Selenium::Server.get(:latest,
    821:  background: true,
    822:  args: %w[--selenium-manager true --enable-managed-downloads true])
    823:  TypeError:
    824:  no implicit conversion of String into Integer
    825:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    826:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    827:  2.2) Failure/Error:
    828:  Selenium::Server.get(:latest,
    829:  background: true,
    830:  args: %w[--selenium-manager true --enable-managed-downloads true])
    831:  TypeError:
    832:  no implicit conversion of String into Integer
    833:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    834:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    835:  3) Remote WebDriver downloads
    836:  Got 0 failures and 2 other errors:
    837:  3.1) Failure/Error:
    838:  Selenium::Server.get(:latest,
    839:  background: true,
    840:  args: %w[--selenium-manager true --enable-managed-downloads true])
    841:  TypeError:
    842:  no implicit conversion of String into Integer
    843:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    844:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    845:  3.2) Failure/Error:
    846:  Selenium::Server.get(:latest,
    847:  background: true,
    848:  args: %w[--selenium-manager true --enable-managed-downloads true])
    849:  TypeError:
    850:  no implicit conversion of String into Integer
    851:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    852:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    853:  Finished in 6 minutes 53 seconds (files took 5.4 seconds to load)
    854:  185 examples, 3 failures, 41 pending
    855:  Failed examples:
    856:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    857:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    858:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    859:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Copy link
    Contributor Author

    renovate bot commented Oct 7, 2024

    Edited/Blocked Notification

    Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

    You can manually request rebase by checking the rebase/retry box above.

    ⚠️ Warning: custom changes will be lost.

    @harsha509 harsha509 merged commit df10d88 into trunk Oct 11, 2024
    12 checks passed
    @harsha509 harsha509 deleted the renovate/rubocop-rspec-3.x-lockfile branch October 11, 2024 22:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant