Skip to content

py: fix line number of driver quit #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Nov 1, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Fixes line number for driver.quit(). Currently it is a blank line.

Motivation and Context

Adds the method instead of the blank line which is useless.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Corrected the line number for the Python driver.quit() example in the documentation.
  • Ensures the documentation accurately reflects the code example, improving clarity for users.

Changes walkthrough 📝

Relevant files
Documentation
_index.en.md
Correct line number for Python `driver.quit()` example     

website_and_docs/content/documentation/webdriver/drivers/_index.en.md

  • Updated the line number for the Python driver.quit() example.
  • Changed from line 13 to line 11 in the code block reference.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Nov 1, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 354d208

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 1, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Accuracy
    Verify that the new line number (11) correctly points to the driver.quit() method in the referenced Python file.

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 1, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 merged commit b8b4a5d into SeleniumHQ:trunk Nov 1, 2024
    3 checks passed
    selenium-ci added a commit that referenced this pull request Nov 1, 2024
    * py: fix line number of driver quit
    
    * change in other languages b8b4a5d
    @Delta456 Delta456 deleted the driver_quit_py branch December 3, 2024 18:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants