Skip to content

docs/selenium_manager: mention about Python now supporting ENV for driver path #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Nov 11, 2024

User description

…iver path

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Mentions Python support for setting ENV for driver path

Motivation and Context

New implemented feature which needs to be documented

image

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Added documentation for Python support for setting the driver path using environment variables.
  • Updated the documentation to reflect that this feature is available in the Selenium Python binding starting from version 4.26.0.
  • Improved formatting by enclosing environment variable names in backticks for clarity.

Changes walkthrough 📝

Relevant files
Documentation
selenium_manager.en.md
Document Python support for environment variable driver path

website_and_docs/content/documentation/selenium_manager.en.md

  • Added Python to the list of bindings supporting environment variable
    for driver path.
  • Updated version information for Python binding support.
  • Formatted environment variable names with backticks.
  • +7/-6     
    selenium_manager.ja.md
    Document Python support for environment variable driver path

    website_and_docs/content/documentation/selenium_manager.ja.md

  • Added Python to the list of bindings supporting environment variable
    for driver path.
  • Updated version information for Python binding support.
  • Formatted environment variable names with backticks.
  • +7/-6     
    selenium_manager.pt-br.md
    Document Python support for environment variable driver path

    website_and_docs/content/documentation/selenium_manager.pt-br.md

  • Added Python to the list of bindings supporting environment variable
    for driver path.
  • Updated version information for Python binding support.
  • Formatted environment variable names with backticks.
  • +7/-6     
    selenium_manager.zh-cn.md
    Document Python support for environment variable driver path

    website_and_docs/content/documentation/selenium_manager.zh-cn.md

  • Added Python to the list of bindings supporting environment variable
    for driver path.
  • Updated version information for Python binding support.
  • Formatted environment variable names with backticks.
  • +7/-6     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Nov 11, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 1e0538b

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Translation Update
    The Japanese translation file has been updated with English content. The text should be properly translated to Japanese.

    Translation Update
    The Portuguese translation file has been updated with English content. The text should be properly translated to Portuguese.

    Translation Update
    The Chinese translation file has been updated with English content. The text should be properly translated to Chinese.

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 11, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Clarify version requirements by explicitly stating that later versions are also supported

    Clarify that the version numbers refer to the minimum required versions for this
    feature, by adding "or later" after the version numbers.

    website_and_docs/content/documentation/selenium_manager.en.md [354]

    -This feature is available in the Selenium Ruby and Python binding starting from version 4.25.0 and 4.26.0.
    +This feature is available in the Selenium Ruby binding starting from version 4.25.0 or later, and in Python binding starting from version 4.26.0 or later.
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: The suggestion improves clarity by explicitly stating that later versions are also supported, which helps prevent potential user confusion about version compatibility. The change makes the documentation more precise without changing its technical meaning.

    6

    💡 Need additional feedback ? start a PR chat

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 self-requested a review November 11, 2024 18:01
    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    HI @Delta456 ,

    Thank you for the PR. Requested few changes!

    @Delta456 Delta456 requested a review from harsha509 November 11, 2024 19:00
    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 merged commit 63af349 into SeleniumHQ:trunk Nov 12, 2024
    3 checks passed
    @Delta456 Delta456 deleted the py_selenium_manager branch November 12, 2024 13:36
    selenium-ci added a commit that referenced this pull request Nov 12, 2024
    …iver path (#2055)[deploy site]
    
    * docs/selenium_manager: mention about Python now supporting ENV for driver path
    
    * commit as what requested
    
    ---------
    
    Co-authored-by: Sri Harsha <[email protected]> 63af349
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants