Try optionally displaying the full file #2273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CI Feedback 🧐(Feedback updated until commit 1cd4dac)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
titusfortner
force-pushed
the
display_full
branch
from
4ff03df to
2080bee
Compare
|
Nopety nope. We can probably get this to work, but it'll involve more hacking on the tab shortcode, not just the gh-codeblock shortcode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
Motivation and Context
We don't want to clutter the documentation with boilerplate code by default, but people often want more context than just the one or two lines that make the method call. This highlights the code we care about and then allows you to display the whole file.
If we're displaying the whole file, it makes sense to split the tests so it is one test per file.
This will also make it much easier to manage line number references. If you make a change to a file, you only need to update the line numbers in one place rather than a bunch of places.
I can't see what I need locally, so using netlify to demo it...
PR Type
Enhancement, Tests, Documentation
Description
Added an optional "Show full example" toggle in code snippets.
Split Ruby test cases into individual files for better organization.
Updated documentation to reflect new file paths and line numbers.
Minor fixes and improvements in Ruby test files.
Changes walkthrough 📝
1 files
Add "Show full example" toggle for code snippets1 files
Add frozen string literal and minor fixes7 files
Add test for Chrome options argumentsAdd test for basic Chrome optionsAdd test for setting Chrome binary locationAdd test for keeping Chrome browser openAdd test for excluding Chrome switchesAdd test for adding Chrome extensionsRefactor and simplify getting started Selenium test9 files
Update Ruby code snippet references for BiDi loggingUpdate Ruby code snippet references for BiDi logging (Japanese)Update Ruby code snippet references for BiDi logging (Portuguese)Update Ruby code snippet references for BiDi logging (Chinese)Update Ruby code snippet references for Chrome optionsUpdate Ruby code snippet references for getting startedUpdate Ruby code snippet references for getting started (Japanese)Update Ruby code snippet references for getting started (Portuguese)Update Ruby code snippet references for getting started (Chinese)