Skip to content

Commit 919c2ea

Browse files
authored
Merge pull request #53 from Shopify/cleanup
Some structural cleanup and updates
2 parents 6d55c89 + ab21f0e commit 919c2ea

File tree

14 files changed

+3
-22
lines changed

14 files changed

+3
-22
lines changed

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ Ruby LSP Rails is a [Ruby LSP](https://github.com/Shopify/ruby-lsp) extension fo
55
- Displaying an ActiveRecord model's database columns and types when hovering over it
66
- (More to come!)
77

8-
98
## Installation
109

1110
To install, add the following line to your application's Gemfile:
@@ -25,7 +24,7 @@ end
2524

2625
This gem consists of two components that enable enhanced Rails functionality in the editor:
2726

28-
1. A Rails engine that automatically exposes APIs when Rails server is running
27+
1. A Rack middleware that automatically exposes APIs when Rails server is running
2928
1. A Ruby LSP extension that connects to the exposed APIs to fetch runtime information from the Rails server
3029

3130
This is why the Rails server needs to be running for features to work.
@@ -35,7 +34,6 @@ This is why the Rails server needs to be running for features to work.
3534
> There is no need to restart the Ruby LSP every time the Rails server is booted.
3635
> If the server is shut down, the extra features will temporarily disappear and reappear once the server is running again.
3736
38-
3937
## Contributing
4038

4139
Bug reports and pull requests are welcome on GitHub at https://github.com/Shopify/ruby-lsp-rails. This project is

lib/ruby_lsp_rails/railtie.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# typed: strict
22
# frozen_string_literal: true
33

4+
require "rails/railtie"
45
require "ruby_lsp_rails/middleware"
56

67
module RubyLsp

sorbet/tapioca/require.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
# Add your extra requires here (`bin/tapioca require` can be used to bootstrap this list)
55

6-
require "rails/all"
76
require "ruby_lsp/internal"
87
require "syntax_tree"
98
require "syntax_tree/dsl"
9+
require "minitest/unit"
1010
require "mocha/minitest"

test/fixtures/files/.keep

Whitespace-only changes.

test/helpers/.keep

Whitespace-only changes.

test/integration/.keep

Whitespace-only changes.

test/integration/navigation_test.rb

Lines changed: 0 additions & 10 deletions
This file was deleted.

test/mailers/.keep

Whitespace-only changes.

test/models/.keep

Whitespace-only changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

test/test_helper.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@
1313
require "ruby_lsp/internal"
1414
require "ruby_lsp/ruby_lsp_rails/extension"
1515

16-
# Load fixtures from the engine
17-
if ActiveSupport::TestCase.respond_to?(:fixture_path=)
18-
ActiveSupport::TestCase.fixture_path = File.expand_path("fixtures", __dir__)
19-
ActionDispatch::IntegrationTest.fixture_path = ActiveSupport::TestCase.fixture_path
20-
ActiveSupport::TestCase.file_fixture_path = ActiveSupport::TestCase.fixture_path + "/files"
21-
ActiveSupport::TestCase.fixtures(:all)
22-
end
23-
2416
$VERBOSE = nil unless ENV["VERBOSE"] || ENV["CI"]
2517

2618
module ActiveSupport

0 commit comments

Comments
 (0)