Some structural cleanup and updates #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventionally, `test/lib` contains helpers or mock objects for tests. Projects like Rails and Ruby's default libraries all follow this convention. So this commit renames `test/lib` to `test/ruby_lsp_rails` as the files in it are in fact tests for the extension.
vinistock
approved these changes
Apr 24, 2023
| require "ruby_lsp/internal" | ||
| require "syntax_tree" | ||
| require "syntax_tree/dsl" | ||
| require "minitest/unit" |
There was a problem hiding this comment.
Won't this print test outputs then running bin/tapioca gem? Is this needed because of mocha?
There was a problem hiding this comment.
Yeah currently mocha yells when bin/tapioca gem is run:
MiniTest must be loaded before
require 'mocha/minitest'. (RuntimeError)
I thought about testing output too but I actually don't see it:
(I will open a separate PR to bump gem rbis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48