Fix Code Lens heredoc handling #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Jul 5, 2023
andyw8
commented
Jul 5, 2023
| @@ -64,6 +64,9 @@ def on_command(node) | |||
| # The test name may be a blank string while the code is being typed | |||
| return if first_argument.parts.empty? | |||
|
|
|||
| # We can't handle interpolation yet | |||
| return unless first_argument.parts.all? { |part| part.is_a?(SyntaxTree::TStringContent) } | |||
There was a problem hiding this comment.
(an interpolated string is represented as an array of SyntaxTree::StringEmbExpr and SyntaxTree::TStringContent)
There was a problem hiding this comment.
Maybe better written as:
return if first_argument.parts.any? { |part| part.is_a?(SyntaxTree::TStringContent) }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't yet decided how to handle interpolation within test case names so we'll ignore them for now.