Skip to content

Standardize path handling #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Standardize path handling #121

merged 1 commit into from
Aug 9, 2023

Conversation

vinistock
Copy link
Member

Similar to what we did in the Ruby LSP, we need to ensure that paths are always handled by Pathname and URIs are always handled by URI to guarantee consistency across different operating systems.

@vinistock vinistock added the enhancement New feature or request label Aug 8, 2023
@vinistock vinistock added this to the 2023-Q3 milestone Aug 8, 2023
@vinistock vinistock self-assigned this Aug 8, 2023
@vinistock vinistock requested a review from a team as a code owner August 8, 2023 20:45
@vinistock vinistock requested review from andyw8 and KaanOzkan August 8, 2023 20:45
@vinistock vinistock force-pushed the vs/standardize_paths branch from 7584333 to dfd300a Compare August 9, 2023 15:33
@vinistock vinistock requested a review from Morriar August 9, 2023 15:34
Base automatically changed from vs/handle_breaking_changes to main August 9, 2023 17:04
@vinistock vinistock merged commit e410c23 into main Aug 9, 2023
@vinistock vinistock deleted the vs/standardize_paths branch August 9, 2023 17:04
@shopify-shipit shopify-shipit bot temporarily deployed to production August 9, 2023 17:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants