Skip to content

Use mocha instead of minitest/mock #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

Use mocha instead of minitest/mock #21

merged 1 commit into from
Apr 18, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 14, 2023 •
edited
Loading

For consistency with other Ruby codebases at Shopify, including ruby_lsp.

@andyw8 andyw8 force-pushed the andyw8/use-mocha branch 4 times, most recently from 5645652 to 04ae2a2 Compare April 17, 2023 21:26
@andyw8 andyw8 changed the title Use mocha Use mocha instead of minitest/mock Apr 17, 2023
@andyw8 andyw8 force-pushed the andyw8/use-mocha branch from 04ae2a2 to c4cf4de Compare April 17, 2023 21:33
@andyw8 andyw8 marked this pull request as ready for review April 18, 2023 17:53
@andyw8 andyw8 requested a review from a team as a code owner April 18, 2023 17:53
@andyw8 andyw8 force-pushed the andyw8/use-mocha branch from c4cf4de to db10cdf Compare April 18, 2023 18:20
@andyw8 andyw8 merged commit 8fb9359 into main Apr 18, 2023
@andyw8 andyw8 deleted the andyw8/use-mocha branch April 18, 2023 19:18
@shopify-shipit shopify-shipit bot temporarily deployed to production April 21, 2023 19:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock