Skip to content

Bump rails from 757f489 to bb5e279 #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2024

Bumps rails from 757f489 to bb5e279.

Commits
  • bb5e279 Add default pwa manifest and service worker file (#50528)
  • 1ea796d Merge pull request #50523 from bparanj/correct-usage-of-named-routes
  • 74ad735 Document correct usage of named routes [skip ci]
  • 1e4f161 Merge pull request #50538 from sato11/rescue-responses-docs
  • 6c0f5f6 Merge pull request #50540 from santib/dependabot-add-gha
  • aa13b51 Add GHA actions to dependabot
  • 42ca4de User content_for for titles in the application layout (#49702)
  • 8397eb2 Remove rollup and test machinery for rails-ujs (#50535)
  • 66c1745 bundle update (#50516)
  • 75dbe78 Resolve documentational ambiguity over rescue_responses [ci-skip]
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner January 3, 2024 13:13
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby labels Jan 3, 2024
@dependabot dependabot bot requested review from st0012 and vinistock January 3, 2024 13:13
@dependabot dependabot bot requested a review from andyw8 January 3, 2024 13:13
@github-actions github-actions bot enabled auto-merge January 3, 2024 13:13
@vinistock vinistock force-pushed the dependabot/bundler/rails-bb5e279 branch from e32c73b to 37ab074 Compare January 3, 2024 13:14
@andyw8
Copy link
Contributor

andyw8 commented Jan 3, 2024

@vinistock
Copy link
Member

vinistock commented Jan 4, 2024

I'm wondering if we can just go back to using Rails releases instead of the main branch. We did this to get a bug fix early and make CI pass, but I'm not sure we're getting a ton of value out of it.

What do you think?

@st0012
Copy link
Member

st0012 commented Jan 4, 2024

I think we can test against Rails main + the latest Ruby release as experimental so we can still easily have a look on potential compatibility issues. But I agree being blocked by Rails main's changes is an unnecessary friction.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 8, 2024

A newer version of rails exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@andyw8
Copy link
Contributor

andyw8 commented Jan 9, 2024

I think we can test against Rails main + the latest Ruby release as experimental so we can still easily have a look on potential compatibility issues. But I agree being blocked by Rails main's changes is an unnecessary friction.

Trying that here: #224

auto-merge was automatically disabled January 9, 2024 20:19

Base branch was modified

@andyw8 andyw8 closed this Jan 9, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/rails-bb5e279 branch January 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants