Only generate app_uri.txt and append Rack app when the server feature is enabled #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the addon client uses the file's existence to determine whether to send the request, if the file is generated when the server feature is disabled, the client would just spam the server with requests. We also don't need to append the Rack app if Rails server is not invoked.
andyw8
approved these changes
Jan 18, 2024
vinistock
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the addon client uses the
tmp/app_uri.txt's existence to determine whether to send the request, if the file is generated when the server feature is disabled, the client would just spam the server with requests.We also don't need to append the Rack app if Rails server is not invoked.