Fallback to NullClient
if initializing server fails
#266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265
Currently, if we fail to initialize the server, we show errors every time hover occurs. The reason is because
initialize
raises, meaning the memoized client is never set and thus causing us to try to initialized it again on every hover.Since the client is bound to be used everywhere in this addon, I think the easiest way of handling it is falling back to a
NullClient
that simply no-ops most operations. That way, we don't have to spread a bunch of conditionals everywhere in the code.Manual tests
Open3.popen3
command frombin/rails
to something that doesn't exist. Likenon-existing-command-test
.