Skip to content

Improve the project's readme #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Improve the project's readme #32

merged 1 commit into from
Apr 18, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 18, 2023

No description provided.

@st0012 st0012 added this to the 2023-Q2 milestone Apr 18, 2023
@st0012 st0012 requested a review from a team as a code owner April 18, 2023 20:03
@st0012 st0012 self-assigned this Apr 18, 2023
@st0012 st0012 added the documentation Improvements or additions to documentation label Apr 18, 2023
@st0012 st0012 merged commit 185bb71 into main Apr 18, 2023
@st0012 st0012 deleted the improve-readme branch April 18, 2023 20:25
@andyw8
Copy link
Contributor

andyw8 commented Apr 18, 2023

Left a few suggestions but not critical.


The RailsRubyLsp is a [Ruby LSP](https://github.com/Shopify/ruby-lsp) extension for extra Rails editor features. As long
as this gem is a part of the project's bundle, the Ruby LSP will automatically load it to provide extra features.
The Rails Ruby Lsp is a [Ruby LSP](https://github.com/Shopify/ruby-lsp) extension for extra Rails editor features, such as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Rails Ruby Lsp is a [Ruby LSP](https://github.com/Shopify/ruby-lsp) extension for extra Rails editor features, such as:
The Rails Ruby LSP is a [Ruby LSP](https://github.com/Shopify/ruby-lsp) extension for extra Rails editor features, such as:

## Usage

1. Start your Rails server
1. Hover over an ActiveRecord model to see its details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Hover over an ActiveRecord model to see its details
1. Hover over an ActiveRecord model class name to see its details

(in case people mistakenly try to hover over the filename, etc.)


This gem consists of two components that enable enhanced Rails functionality in the editor:

1. A Rails engine that automatically exposes APIs when Rails server is running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. A Rails engine that automatically exposes APIs when Rails server is running
1. A Rails engine that exposes APIs while the Rails server is running.

@shopify-shipit shopify-shipit bot temporarily deployed to production April 21, 2023 19:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants