Don't push group id to stack when encountering non-test classes #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests use classes instead of modules for namespacing, such us:
```ruby
module Foo
class Bar
class MyTest < ActiveSupport::TestCase
test "something" do
end
end
end
end
```
And when this happens, the current implementation would still push the
group id to the stack, which would cause the first test group (`MyTest`)
to already have non-nil group id. This will make the extension to think
there's another parent test group, which is not the case and will cause
no code lens to be shown.
This commit fixes this by not pushing the group id to the stack when
encountering non-test classes, and only pop the group id when the
encountered class is a test class.
vinistock
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests use classes instead of modules for namespacing, such us:
And when this happens, the current implementation would still push the group id to the stack, which would cause the first test group (
MyTest) to already have non-nil group id. This will make the extension to think there's another parent test group, which is not the case and will cause no code lens to be shown.This commit fixes this by not pushing the group id to the stack when encountering non-test classes, and only pop the group id when the encountered class is a test class.