Avoid Sorbet DSL for dummy app #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/avoid-sorbet-dsl-for-dummy-app
branch
from
1d2732b to
0a491ec
Compare
egiurleo
approved these changes
Apr 15, 2024
vinistock
reviewed
Apr 15, 2024
.rubocop.yml
Outdated
| @@ -26,6 +26,7 @@ Sorbet/TrueSigil: | |||
| Exclude: | |||
| - "**/*.rake" | |||
| - "lib/**/*.rb" | |||
| - "test/**/*.rb" | |||
There was a problem hiding this comment.
This should be test/dummy/**/*.rb. We still want to use typed: true in tests.
andyw8
force-pushed
the
andyw8/avoid-sorbet-dsl-for-dummy-app
branch
from
0a491ec to
18dbe99
Compare
andyw8
force-pushed
the
andyw8/avoid-sorbet-dsl-for-dummy-app
branch
from
18dbe99 to
d693754
Compare
andyw8
force-pushed
the
andyw8/avoid-sorbet-dsl-for-dummy-app
branch
from
d693754 to
36e8924
Compare
vinistock
approved these changes
Apr 15, 2024
aryan-soni
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there much's benefit in using the Tapioca DSLs for the Rails dummy app. Also, there are cases we we want to verify how the LSP behaves for invalid code, e.g. trying to use Go To Definition for an invalid route.