Skip to content

Adjust Rails docs logging #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

Adjust Rails docs logging #338

merged 1 commit into from
Apr 17, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 16, 2024

  • The trailing dots made it look like it's stuck doing something.
  • Phrasing it as 'documents' felt a bit strange.

@andyw8 andyw8 added the chore Chore task label Apr 16, 2024
@andyw8 andyw8 requested a review from a team as a code owner April 16, 2024 18:23
@andyw8 andyw8 requested review from st0012 and aryan-soni April 16, 2024 18:23
vinistock
vinistock reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We've also received feedback a few times that people thought it was stuck because it says Fetching docs, but never says it finished doing it.

Should we add another print when it's done to avoid that confusion?

@andyw8 andyw8 force-pushed the andyw8/adjust-rails-docs-logging branch from dde1ece to 73f4cb5 Compare April 17, 2024 14:28
@andyw8
Copy link
Contributor Author

andyw8 commented Apr 17, 2024

Updated with @vinistock's suggestion.

@andyw8 andyw8 enabled auto-merge (squash) April 17, 2024 14:28
@andyw8 andyw8 merged commit 229d72b into main Apr 17, 2024
@andyw8 andyw8 deleted the andyw8/adjust-rails-docs-logging branch April 17, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock left review comments

@aryan-soni aryan-soni aryan-soni approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyw8 @vinistock @aryan-soni