Skip to content

Rename gem to ruby-lsp-rails #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Rename gem to ruby-lsp-rails #34

merged 1 commit into from
Apr 19, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 18, 2023

As discussed on Slack with @vinistock, @st0012 and @paracycle, we will rename the gem to help establish a convention of ruby-lsp-* for future extensions.

A ticket has been submitted to the helpdesk to rename the repo.

FYI @dirceu

vinistock

This comment was marked as resolved.

@vinistock

This comment was marked as resolved.

@@ -1,7 +0,0 @@
# typed: strict
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed a few unneeded Rails files.

vinistock

This comment was marked as resolved.

@st0012

This comment was marked as resolved.

@andyw8 andyw8 force-pushed the andyw8/rename-gem branch 2 times, most recently from 6daea0f to 9af9281 Compare April 19, 2023 15:16
@andyw8 andyw8 marked this pull request as ready for review April 19, 2023 15:18
@andyw8 andyw8 requested a review from a team as a code owner April 19, 2023 15:18
@andyw8 andyw8 force-pushed the andyw8/rename-gem branch from 9af9281 to cc65dd5 Compare April 19, 2023 15:20
@andyw8 andyw8 changed the title WIP: Proposal to rename gem Rename gem to ruby-lsp-rails Apr 19, 2023
@dirceu
Copy link

dirceu commented Apr 19, 2023

I've renamed the repo 👍

@andyw8 andyw8 merged commit a85d619 into main Apr 19, 2023
@andyw8 andyw8 deleted the andyw8/rename-gem branch April 19, 2023 15:44
@shopify-shipit shopify-shipit bot temporarily deployed to production April 21, 2023 19:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants