Skip to content

Only check schema_path for ActiveRecord classes #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Only check schema_path for ActiveRecord classes #37

merged 1 commit into from
Apr 19, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 19, 2023 •
edited
Loading

I noticed this was making an unnecessary lookup for every constant hover.

@andyw8 andyw8 requested a review from a team as a code owner April 19, 2023 18:47
vinistock
vinistock approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@andyw8 andyw8 merged commit fbe777c into main Apr 19, 2023
@andyw8 andyw8 deleted the andyw8/only-check-schema-path-for-activerecord-classes branch April 19, 2023 18:50
@shopify-shipit shopify-shipit bot temporarily deployed to production April 21, 2023 19:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock