Set up DB for tests as part of default Rake task #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
May 9, 2024
| @@ -30,4 +30,4 @@ end | |||
|
|
|||
| RubyLsp::CheckDocs.new(FileList["#{__dir__}/lib/ruby_lsp/**/*.rb"], FileList["#{__dir__}/misc/**/*.gif"]) | |||
|
|
|||
| task default: :test | |||
| task default: [:"db:setup", :test] | |||
There was a problem hiding this comment.
Previous we were running db:migrate too but since db:setup calls db:schema:load, this isn't necessary.
vinistock
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time someone cloned and runs the tests, they'll get a confusing error because the dB doesn't yet exist.
I originally considered checking if the DB exists first, but creating is very quick so I don't think that's necessary.
(for sqlite3 at least,
db:setupis idempotent so there's no problem with it being re-run. We don't care about the data in the DB).