Use NodeContext from RubyLSP to fix Definition targetting #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2024
andyw8
force-pushed
the
andyw8/use-ruby-lsp-nodecontext
branch
from
1f03ae7 to
70b1e4a
Compare
andyw8
force-pushed
the
andyw8/use-ruby-lsp-nodecontext
branch
from
70b1e4a to
9c4d411
Compare
andyw8
force-pushed
the
andyw8/use-ruby-lsp-nodecontext
branch
from
576f253 to
0c486f8
Compare
vinistock
requested changes
Jun 10, 2024
andyw8
force-pushed
the
andyw8/use-ruby-lsp-nodecontext
branch
from
0c486f8 to
79a0329
Compare
andyw8
force-pushed
the
andyw8/use-ruby-lsp-nodecontext
branch
from
79a0329 to
d9b6661
Compare
vinistock
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made an addition to Ruby LSP which to add call node information to
NodeContext. This means we can now fix the Ruby LSP Rails beahavior for various DSL calls.For example, previously when you had an association
has_many :widgets, the Go To Definition feature would only work if triggered on thehas_manytoken. Now it works for the:widgetstoken, as originally intended.