Do not fail on first activation #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Apr 20, 2023
vinistock
force-pushed
the
vs/do_not_fail_on_first_activation
branch
4 times, most recently
from
297b2ce to
8707c9c
Compare
vinistock
force-pushed
the
vs/do_not_fail_on_first_activation
branch
from
8707c9c to
ed314ae
Compare
andyw8
reviewed
Apr 20, 2023
andyw8
reviewed
Apr 20, 2023
| # If the RailsClient singleton was initialized in a different test successfully, then there would be no chance | ||
| # for this assertion to pass. We need to reset the singleton instance in order to force `initialize` to be | ||
| # executed again | ||
| Singleton.send(:__init__, RailsClient) |
There was a problem hiding this comment.
TIL (was looking for something like this recently).
andyw8
approved these changes
Apr 20, 2023
Co-authored-by: Andy Waite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Check if the app_uri file exists and raise in case it doesn't with a message explaining what the user needs to do to activate the extension properly.