Skip to content

Improve features documentation #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Improve features documentation #445

merged 2 commits into from
Sep 3, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 30, 2024

Closes https://github.com/Shopify/team-ruby-dx/issues/1241

The idea is to keep things simple and prioritize content creation. Therefore, we decided to display features similar to rust-analyzer does.

  • Add FEATURES.md to display supported features with demonstration gifs
  • Update readme to point to the new features page
  • Some minor tweaks

Quick Preview

Screen.Recording.2024-08-30.at.22.02.45.mov

@st0012 st0012 added the documentation Improvements or additions to documentation label Aug 30, 2024
@st0012 st0012 self-assigned this Aug 30, 2024
@st0012 st0012 marked this pull request as ready for review August 30, 2024 21:01
@st0012 st0012 requested a review from a team as a code owner August 30, 2024 21:01
@st0012 st0012 requested review from andyw8 and vinistock August 30, 2024 21:01
@st0012 st0012 force-pushed the improve-documentation branch from d4182af to 314da6f Compare September 3, 2024 18:32
@@ -0,0 +1,98 @@
# Features

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to add table of contents because RDoc generates header anchors in a weird format, like label-Document+Symbol for Document Symbol, instead of just document-symbol.
Since snapper already has a table of contents on the side, it should be fine.

@st0012 st0012 requested a review from vinistock September 3, 2024 18:36
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@st0012 st0012 merged commit af65b74 into main Sep 3, 2024
40 checks passed
@st0012 st0012 deleted the improve-documentation branch September 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants