Find the correct project root when using custom bundle #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
approved these changes
Apr 21, 2023
st0012
reviewed
Apr 21, 2023
Co-authored-by: Stan Lo <[email protected]>
vinistock
deleted the
vs/find_correct_project_root_when_using_custom_bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're pointing the custom bundle to the
.ruby-lspfolder, then the project root is one folder above of it. We need to account for this when discovering the root.I also fixed the
bin/railsscript which was broke after changing strategy to use a middleware. The schema file was changed possibly because it had some RuboCop changes. Those weren't really relevant, so I just updated to what Rails dumps for us.