Avoid need for special VOID return #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/avoid-void
branch
from
d3f6586 to
4e047db
Compare
andyw8
force-pushed
the
andyw8/avoid-void
branch
from
eb4c013 to
4b5e5a7
Compare
andyw8
commented
Sep 18, 2024
| VOID = Object.new | ||
|
|
||
| def initialize | ||
| def initialize(stdout: $stdout, override_default_output_device: true) |
vinistock
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we already done for Ruby LSP, we can restructure things to avoid the need for the artificial 'void' concept.