Use log trace instead of printing to stderr #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs-use-trace-instead-of-printing-to-stderr
branch
3 times, most recently
from
9cf869c to
fcbc3a1
Compare
st0012
approved these changes
Oct 2, 2024
vinistock
force-pushed
the
vs-use-trace-instead-of-printing-to-stderr
branch
2 times, most recently
from
17fa3f4 to
572da64
Compare
vinistock
force-pushed
the
vs-use-trace-instead-of-printing-to-stderr
branch
from
572da64 to
8002896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all of our
stderrprints to use proper log trace messages. As an added benefit, this change revealed a lot of brittleness in our tests, which I fixed by ensuring that we properly await the activation of the addon before trying to run any requests.The tests are a touch slower, but it's significantly less likely to get into a weird state with orphan threads still running even after the tests are finished.
The output has also been cleared since we are no longer printing anything to stderr, so running the tests doesn't pollute the terminal.
Note
There are still a few prints in the Rails documentation client, but I think we should remove that feature altogether now that the Ruby LSP has better support for showing documentation on hover.