Skip to content

Add default and null info on hover #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

damienlethiec
Copy link
Contributor

@damienlethiec damienlethiec commented Oct 25, 2024

To get rid of annotate in my apps, the only missing thing in my opinion is displaying defaults and null information for the model on hover.

This small PR tries to solve this problem.

CleanShot 2024-10-26 at 01 35 52@2x

Please let me know if it needs improvements 🙂

@damienlethiec damienlethiec requested a review from a team as a code owner October 25, 2024 23:38
@damienlethiec
Copy link
Contributor Author

I have signed the CLA!

@damienlethiec
Copy link
Contributor Author

@Mapiou

Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good, just a few suggestions.

@damienlethiec
Copy link
Contributor Author

Thanks for the review @andyw8 . I made the changes 🙂

@andyw8 andyw8 added the enhancement New feature or request label Oct 30, 2024
@andyw8 andyw8 merged commit 04d4dcb into Shopify:main Oct 30, 2024
15 checks passed
@andyw8
Copy link
Contributor

andyw8 commented Oct 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants