Skip to content

Remove dead constant MAX_RETRIES #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shopify-codedb[bot]
Copy link
Contributor

@shopify-codedb shopify-codedb bot commented Nov 2, 2024

This constant appears to be unused and could be removed.

Before approving this pull-request, please double-check that it is indeed unused.

If this code is actually used, please add a comment explaining why and close this pull-request.

@shopify-codedb shopify-codedb bot requested a review from a team as a code owner November 2, 2024 00:35
@andyw8 andyw8 enabled auto-merge (squash) November 2, 2024 12:38
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the usage was removed in #498. Thanks Code DB!

@andyw8 andyw8 merged commit eb0c3a9 into main Nov 4, 2024
28 checks passed
@andyw8 andyw8 deleted the remove-deadcode-rubylsp-rails-runnerclient-max_retries branch November 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants