Change how we warn about server not running #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Jun 22, 2023
| @@ -13,8 +13,6 @@ | |||
| require "ruby_lsp/internal" | |||
| require "ruby_lsp/ruby_lsp_rails/extension" | |||
|
|
|||
| $VERBOSE = nil unless ENV["VERBOSE"] || ENV["CI"] | |||
There was a problem hiding this comment.
This was added to reduce noise in test outout, but it was preventing us from asserting against stderr.
andyw8
commented
Jun 22, 2023
| @@ -22,23 +22,6 @@ class RailsClientTest < ActiveSupport::TestCase | |||
| assert_equal(expected_response, RailsClient.instance.model("User")) | |||
| end | |||
|
|
|||
| test "raises during instantiation if app_uri file doesn't exist" do | |||
There was a problem hiding this comment.
No longer relevant since we don't do anything during instantiation.
andyw8
commented
Jun 23, 2023
| @@ -13,7 +13,6 @@ class Extension < ::RubyLsp::Extension | |||
|
|
|||
| sig { override.void } | |||
| def activate | |||
| # Must be the last statement in activate since it raises to display a notification for the user | |||
There was a problem hiding this comment.
No longer relevant since we don't raise.
egiurleo
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are legitimate cases why someone may want to edit code without the server running, so we want to avoid over-notifying. In this PR, we are changing the behaviour so that we output a notice in the logs, rather than showing an error dialog.
We should also update the README to explain how some features only available if the server is running, but since there is only currently one feature (Hover), it probably makes more sense to do that after Code Lens is added in #67.
Paired on with @vinistock