Skip to content

Update README for Code Lens features #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jun 27, 2023

Covering the new functionality added in #67.

@andyw8 andyw8 requested a review from a team as a code owner June 27, 2023 15:42
@andyw8 andyw8 added the chore Chore task label Jun 27, 2023
@@ -17,17 +17,29 @@ end

## Usage

### Hover to reveal ActiveRecord schema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These features are all listed as part of our documentation generated by RDoc. Should we link to there instead to avoid repeating ourselves?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but it's not the most appealing format, e.g. https://shopify.github.io/ruby-lsp-rails/RubyLsp/Rails/Hover.html

Maybe the README can act as a brief summary of the behaviour, and we can link to the docs for more detail? That's something I commonly see for other gem's READMEs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's at least limit the README to a few examples. Otherwise, we're documenting the same thing twice, which increases the likelihood we'll forget to update the documentation if anything changes.

Co-authored-by: Vinicius Stock <[email protected]>
@@ -17,17 +17,29 @@ end

## Usage

### Hover to reveal ActiveRecord schema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's at least limit the README to a few examples. Otherwise, we're documenting the same thing twice, which increases the likelihood we'll forget to update the documentation if anything changes.

@andyw8 andyw8 merged commit 4a5c065 into main Jun 27, 2023
@andyw8 andyw8 deleted the andyw8/update-readme-for-code-lens branch June 27, 2023 18:52
@shopify-shipit shopify-shipit bot temporarily deployed to production June 30, 2023 19:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants