Skip to content

Add link to docs #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Add link to docs #95

merged 1 commit into from
Jun 28, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jun 28, 2023

No description provided.

@andyw8 andyw8 force-pushed the andyw8/add-link-to-docs branch from 1670691 to 4e3aef1 Compare June 28, 2023 14:56
@andyw8 andyw8 force-pushed the andyw8/add-link-to-docs branch from 4e3aef1 to 83cbc5f Compare June 28, 2023 15:24
@andyw8 andyw8 force-pushed the andyw8/add-link-to-docs branch from 83cbc5f to c014339 Compare June 28, 2023 15:24
# # Supported features
#
# - [Hover](rdoc-ref:RubyLsp::Rails::Hover)
# - [CodeLens](rdoc-ref:RubyLsp::Rails::CodeLens)
Copy link
Contributor Author

@andyw8 andyw8 Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinistock I added this as an equivalent to https://shopify.github.io/ruby-lsp/RubyLsp/Requests.html, so we have somewhere to link to directly, does it seem suitable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great idea. I think this is the place to put it.

@andyw8 andyw8 added the chore Chore task label Jun 28, 2023
@andyw8 andyw8 marked this pull request as ready for review June 28, 2023 15:28
@andyw8 andyw8 requested a review from a team as a code owner June 28, 2023 15:28
# # Supported features
#
# - [Hover](rdoc-ref:RubyLsp::Rails::Hover)
# - [CodeLens](rdoc-ref:RubyLsp::Rails::CodeLens)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great idea. I think this is the place to put it.

@@ -15,6 +15,7 @@ group :development do
end
```


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@andyw8 andyw8 merged commit 37f3ffa into main Jun 28, 2023
@andyw8 andyw8 deleted the andyw8/add-link-to-docs branch June 28, 2023 16:04
@shopify-shipit shopify-shipit bot temporarily deployed to production June 30, 2023 19:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants