Skip to content

Bump rubocop from 1.49.0 to 1.50.0 #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Bump rubocop from 1.49.0 to 1.50.0 #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce9aa77
Bump rubocop from 1.49.0 to 1.50.0
dependabot[bot] Apr 11, 2023
66ae0c3
Dump config
sambostock Apr 11, 2023
75a595d
Enable `Lint/DuplicateMatchPattern`
sambostock Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
rubocop-shopify (2.12.0)
rubocop (~> 1.49)
rubocop (~> 1.50)

GEM
remote: https://rubygems.org/
Expand All @@ -27,7 +27,7 @@ GEM
rake (13.0.6)
regexp_parser (2.7.0)
rexml (3.2.5)
rubocop (1.49.0)
rubocop (1.50.0)
json (~> 2.3)
parallel (~> 1.10)
parser (>= 3.2.0.0)
Expand Down
2 changes: 1 addition & 1 deletion rubocop-shopify.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ Gem::Specification.new do |s|

s.required_ruby_version = ">= 2.7.0"

s.add_dependency("rubocop", "~> 1.49")
s.add_dependency("rubocop", "~> 1.50")
end
3 changes: 3 additions & 0 deletions rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ Lint/DuplicateElsifCondition:
Lint/DuplicateMagicComment:
Enabled: true

Lint/DuplicateMatchPattern:
Enabled: true

Lint/DuplicateRegexpCharacterClassElement:
Enabled: false

Expand Down
8 changes: 4 additions & 4 deletions test/fixtures/full_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,8 +682,6 @@ Layout/LineContinuationLeadingSpace:
Layout/LineContinuationSpacing:
Description: Checks the spacing in front of backslash in line continuations.
Enabled: false
AutoCorrect: true
SafeAutoCorrect: true
VersionAdded: '1.31'
EnforcedStyle: space
SupportedStyles:
Expand Down Expand Up @@ -1245,6 +1243,10 @@ Lint/DuplicateMagicComment:
Description: Check for duplicated magic comments.
Enabled: true
VersionAdded: '1.37'
Lint/DuplicateMatchPattern:
Description: Do not repeat patterns in `in` keywords.
Enabled: true
VersionAdded: '1.50'
Lint/DuplicateMethods:
Description: Check for duplicate method definitions.
Enabled: true
Expand Down Expand Up @@ -2785,7 +2787,6 @@ Style/FileEmpty:
is empty.
Enabled: true
Safe: false
SafeAutoCorrect: false
VersionAdded: '1.48'
Style/FileRead:
Description: Favor `File.(bin)read` convenience methods.
Expand Down Expand Up @@ -3434,7 +3435,6 @@ Style/NumericPredicate:
comparisons.
StyleGuide: "#predicate-methods"
Safe: false
SafeAutoCorrect: false
Enabled: false
VersionAdded: '0.42'
VersionChanged: '0.59'
Expand Down