Loop Expression System Enhancement | DEVS

[cooffeeRequired]

Description

This PR introduces a new abstract system for working with loop expressions in Skript, which simplifies implementation and improves code clarity.

Main Changes:

1. Added new AbstractLoopExpression class for basic loop expression functionality
2. Added new AbstractExpressionInitializer class for loop expression initialization

Implementation Examples

1. Basic Loop Expression

public class CustomToLoopExpression extends SimpleExpression<String> {
    static {
        Skript.registerExpression(CustomToLoopExpression.class, String.class, ExpressionType.SIMPLE, "custom loop section");
    }

    @Override
    protected String @Nullable [] get(Event event) {
        return new String[] { "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z" };
    }

    @Override
    public boolean isSingle() {
        return false;
    }

    @Override
    public Class<? extends String> getReturnType() {
        return String.class;
    }

    @Override
    public String toString(@Nullable Event event, boolean debug) {
        return "custom loop section";
    }

    @Override
    public boolean init(Expression<?>[] expressions, int matchedPattern, Kleenean isDelayed, SkriptParser.ParseResult parseResult) {
        return true;
    }
}

public class LoopCustomExpression extends AbstractLoopExpression<Object> {
    static {
        register(LoopCustomExpression.class, Object.class, "custom");
    }

    @Override
    public boolean isIntendedLoop(SecLoop loop, AbstractExpressionInitializer initializer) {
        // any condition, similar as like init method in SimpleExpression
        return true;
    }

    @Override
    public Class<? extends Expression<?>> getExpressionToLoop() {
        return CustomToLoopExpression.class;
    }

    @Override
    protected Object[] get(Event event) {
        return new Object[] { loop.getCurrent(event) };
    }
}

Usage in Skript

# Basic usage
loop custom loop section:
    send loop-custom

Technical Details

• AbstractLoopExpression provides basic functionality for all loop expressions
• AbstractExpressionInitializer ensures proper initialization of loop expressions

---

Target Minecraft Versions: any

[APickledWalrus]

Thank you very much for the contribution. My current concern is that this conflicts with ExprLoopValue to some extent. I think any system should integrate with that rather than registering new patterns. I had started some work on that (as part of upcoming context changes), so this feature might be better left to the core team.

[cooffeeRequired]

Okey thank you for answering. Would you sent your concepts