Skip to content

EvtHarvestBlock #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: dev/feature
Choose a base branch
from
Open

EvtHarvestBlock #7903

wants to merge 12 commits into from

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented May 30, 2025 •
edited
Loading

Problem

Skript has no support for the PlayerHarvestBlockEvent.

Solution

Adds PlayerHarvestBlockEvent which allows users to detect when a block, like sweet berry bushes, are harvested.
Includes event values for the block, the player, the drops, the the equipment slot, and the slot.

Testing Completed

EvtHarvestBlockTest.sk

Supporting Information

N/A

Completes: none
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner May 30, 2025 19:32
@Absolutionism Absolutionism requested review from Efnilite and cheeezburga and removed request for a team May 30, 2025 19:32
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 30, 2025
Fusezion
Fusezion reviewed May 30, 2025
View reviewed changes
Fusezion
Fusezion suggested changes May 30, 2025
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to either include it in ExprDrops or make a new "harvest drops" expression for modifying the drops in a harvest event

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerHarvestBlockEvent.html#getItemsHarvested()

@Absolutionism Absolutionism requested a review from Fusezion May 30, 2025 21:18
sovdeeth
sovdeeth requested changes May 30, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from sovdeeth May 31, 2025 05:13
Efnilite
Efnilite requested changes Jun 2, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from Efnilite June 2, 2025 13:21
@sovdeeth sovdeeth moved this to Needs Reviews in 2.12 Release Jun 3, 2025
@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Jun 3, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jun 3, 2025
@erenkarakal erenkarakal added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 3, 2025
@erenkarakal erenkarakal moved this from Needs Reviews to Awaiting Merge in 2.12 Release Jun 3, 2025
Efnilite
Efnilite requested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good after this 🔥

@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 4, 2025
@Absolutionism Absolutionism requested a review from Efnilite June 4, 2025 13:54
@erenkarakal erenkarakal moved this from Awaiting Merge to In Review in 2.12 Release Jun 5, 2025
Efnilite
Efnilite requested changes Jun 7, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from Efnilite June 7, 2025 15:06
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 12, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Release Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@erenkarakal erenkarakal erenkarakal approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

@Fusezion Fusezion Awaiting requested review from Fusezion

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
2.12 Release
Status: Awaiting Merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Absolutionism @sovdeeth @Efnilite @erenkarakal @Fusezion