Facing Relative Vector Offset #7925
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
Burbulinis and
TheMug06
and removed request for
a team
erenkarakal
changed the title
UnderscoreTud
requested changes
Jun 6, 2025
Comment on lines
+96
to
+99
| Vector o = new Vector(0, 0, 0); | ||
| o.add(left.multiply(offset.getX())); | ||
| o.add(up.multiply(offset.getY())); | ||
| o.add(forward.multiply(offset.getZ())); |
There was a problem hiding this comment.
Why not initialize the XYZ values directly?
sovdeeth
requested changes
Jun 6, 2025
| */ | ||
| private static Location getFacingRelativeOffset(Location loc, Vector offset) { | ||
| Vector forward = loc.getDirection(); | ||
| Vector up = new Vector(0, 1, 0); |
There was a problem hiding this comment.
this isn't actually the local up direction
There was a problem hiding this comment.
You may want to replace this whole method with Quaternionf.rotationZYX and use that to transform the vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There isn't a shorthand way to offset a location while considering rotation.
Solution
Adds a new pattern to the existing offset syntax. This can be compared to ^^^ in vanilla commands (like
/summon tnt ^1 ^2 ^3)before:
with this PR:
and this isn't even showing the work you would've done to achieve an X or Y offset at the same time
I was going to update the syntax description but not sure how I should explain this
Testing Completed
Only manual testing was done, comparing the syntax to the vanilla Minecraft command
Completes: none
Related: none