preInit Follow Up + SectionExpression#isSectionOnly #7929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new
#preInit
method that was added, was only taken advantage of inSimpleExpression
allowing default implementation ofSyntaxRuntimeErrorProducer
and was not done forEffect
,Condition
andSection
.There was no API to distinguish if a
SectionExpression
could only be used as aSection
.Solution
Overrides
#preInit
inEffect
,Condition
, andSection
setting theNode
and implementingSyntaxRuntimeErrorProducer
allowing all elements by default to have access to it. Including sub types that elements extend such asEffectSection
andSectionExpression
Adds a
#isSectionOnly
inSectionExpression
allowing to check if it can only be used as aSection
.ExpressionSection
where if theSectionNode
is null andSectionExpression#isSectionOnly
returns true, prints an error and returns false inExpressionSection#init
.Testing Completed
N/A
Supporting Information
N/A
Completes: none
Related: none