Skip to content

Expose error codes in exceptions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2017
Merged

Expose error codes in exceptions #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a461e7
Expose error codes
zauguin Feb 6, 2017
0669af2
Simplified sqlite_exception construction
zauguin Feb 7, 2017
de9bb36
Add error codes for no_row and more_rows
zauguin Feb 7, 2017
a22241e
Add documentation and change error codes to int
zauguin Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ Errors
----

On error, the library throws an error class indicating the type of error. The error classes are derived from the SQLITE3 error names, so if the error code is SQLITE_CONSTRAINT, the error class thrown is sqlite::exceptions::constraint. Note that all errors are derived from sqlite::sqlite_exception and that itself is derived from std::runtime_exception.
sqlite::sqlite_exception has a get_code() member function to get the SQLITE3 error code.

```c++
database db(":memory:");
Expand All @@ -297,7 +298,7 @@ On error, the library throws an error class indicating the type of error. The er
/* if you are trying to catch all sqlite related exceptions
* make sure to catch them by reference */
catch (sqlite_exception& e) {
cerr << e.what() << endl;
cerr << e.get_code() << ": " << e.what() << endl;
}
/* you can catch specific exceptions as well,
catch(sqlite::exceptions::constraint e) { } */
Expand Down
67 changes: 36 additions & 31 deletions hdr/sqlite_modern_cpp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,13 @@

namespace sqlite {

struct sqlite_exception: public std::runtime_error {
sqlite_exception(const char* msg):runtime_error(msg) {}
class sqlite_exception: public std::runtime_error {
public:
sqlite_exception(const char* msg, int code = -1): runtime_error(msg), code(code) {}
sqlite_exception(int code): runtime_error(sqlite3_errstr(code)), code(code) {}
int get_code() {return code;}
private:
int code;
};

namespace exceptions {
Expand Down Expand Up @@ -70,33 +75,33 @@ namespace sqlite {
class no_rows: public sqlite_exception { using sqlite_exception::sqlite_exception; };

static void throw_sqlite_error(const int& error_code) {
if(error_code == SQLITE_ERROR) throw exceptions::error(sqlite3_errstr(error_code));
else if(error_code == SQLITE_INTERNAL) throw exceptions::internal (sqlite3_errstr(error_code));
else if(error_code == SQLITE_PERM) throw exceptions::perm(sqlite3_errstr(error_code));
else if(error_code == SQLITE_ABORT) throw exceptions::abort(sqlite3_errstr(error_code));
else if(error_code == SQLITE_BUSY) throw exceptions::busy(sqlite3_errstr(error_code));
else if(error_code == SQLITE_LOCKED) throw exceptions::locked(sqlite3_errstr(error_code));
else if(error_code == SQLITE_NOMEM) throw exceptions::nomem(sqlite3_errstr(error_code));
else if(error_code == SQLITE_READONLY) throw exceptions::readonly(sqlite3_errstr(error_code));
else if(error_code == SQLITE_INTERRUPT) throw exceptions::interrupt(sqlite3_errstr(error_code));
else if(error_code == SQLITE_IOERR) throw exceptions::ioerr(sqlite3_errstr(error_code));
else if(error_code == SQLITE_CORRUPT) throw exceptions::corrupt(sqlite3_errstr(error_code));
else if(error_code == SQLITE_NOTFOUND) throw exceptions::notfound(sqlite3_errstr(error_code));
else if(error_code == SQLITE_FULL) throw exceptions::full(sqlite3_errstr(error_code));
else if(error_code == SQLITE_CANTOPEN) throw exceptions::cantopen(sqlite3_errstr(error_code));
else if(error_code == SQLITE_PROTOCOL) throw exceptions::protocol(sqlite3_errstr(error_code));
else if(error_code == SQLITE_EMPTY) throw exceptions::empty(sqlite3_errstr(error_code));
else if(error_code == SQLITE_SCHEMA) throw exceptions::schema(sqlite3_errstr(error_code));
else if(error_code == SQLITE_TOOBIG) throw exceptions::toobig(sqlite3_errstr(error_code));
else if(error_code == SQLITE_CONSTRAINT) throw exceptions::constraint(sqlite3_errstr(error_code));
else if(error_code == SQLITE_MISMATCH) throw exceptions::mismatch(sqlite3_errstr(error_code));
else if(error_code == SQLITE_MISUSE) throw exceptions::misuse(sqlite3_errstr(error_code));
else if(error_code == SQLITE_NOLFS) throw exceptions::nolfs(sqlite3_errstr(error_code));
else if(error_code == SQLITE_AUTH) throw exceptions::auth(sqlite3_errstr(error_code));
else if(error_code == SQLITE_FORMAT) throw exceptions::format(sqlite3_errstr(error_code));
else if(error_code == SQLITE_RANGE) throw exceptions::range(sqlite3_errstr(error_code));
else if(error_code == SQLITE_NOTADB) throw exceptions::notadb(sqlite3_errstr(error_code));
else throw sqlite_exception(sqlite3_errstr(error_code));
if(error_code == SQLITE_ERROR) throw exceptions::error(error_code);
else if(error_code == SQLITE_INTERNAL) throw exceptions::internal (error_code);
else if(error_code == SQLITE_PERM) throw exceptions::perm(error_code);
else if(error_code == SQLITE_ABORT) throw exceptions::abort(error_code);
else if(error_code == SQLITE_BUSY) throw exceptions::busy(error_code);
else if(error_code == SQLITE_LOCKED) throw exceptions::locked(error_code);
else if(error_code == SQLITE_NOMEM) throw exceptions::nomem(error_code);
else if(error_code == SQLITE_READONLY) throw exceptions::readonly(error_code);
else if(error_code == SQLITE_INTERRUPT) throw exceptions::interrupt(error_code);
else if(error_code == SQLITE_IOERR) throw exceptions::ioerr(error_code);
else if(error_code == SQLITE_CORRUPT) throw exceptions::corrupt(error_code);
else if(error_code == SQLITE_NOTFOUND) throw exceptions::notfound(error_code);
else if(error_code == SQLITE_FULL) throw exceptions::full(error_code);
else if(error_code == SQLITE_CANTOPEN) throw exceptions::cantopen(error_code);
else if(error_code == SQLITE_PROTOCOL) throw exceptions::protocol(error_code);
else if(error_code == SQLITE_EMPTY) throw exceptions::empty(error_code);
else if(error_code == SQLITE_SCHEMA) throw exceptions::schema(error_code);
else if(error_code == SQLITE_TOOBIG) throw exceptions::toobig(error_code);
else if(error_code == SQLITE_CONSTRAINT) throw exceptions::constraint(error_code);
else if(error_code == SQLITE_MISMATCH) throw exceptions::mismatch(error_code);
else if(error_code == SQLITE_MISUSE) throw exceptions::misuse(error_code);
else if(error_code == SQLITE_NOLFS) throw exceptions::nolfs(error_code);
else if(error_code == SQLITE_AUTH) throw exceptions::auth(error_code);
else if(error_code == SQLITE_FORMAT) throw exceptions::format(error_code);
else if(error_code == SQLITE_RANGE) throw exceptions::range(error_code);
else if(error_code == SQLITE_NOTADB) throw exceptions::notadb(error_code);
else throw sqlite_exception(error_code);
}
}

Expand Down Expand Up @@ -183,11 +188,11 @@ namespace sqlite {
if((hresult = sqlite3_step(_stmt.get())) == SQLITE_ROW) {
call_back();
} else if(hresult == SQLITE_DONE) {
throw exceptions::no_rows("no rows to extract: exactly 1 row expected");
throw exceptions::no_rows("no rows to extract: exactly 1 row expected", SQLITE_DONE);
}

if((hresult = sqlite3_step(_stmt.get())) == SQLITE_ROW) {
throw exceptions::more_rows("not all rows extracted");
throw exceptions::more_rows("not all rows extracted", SQLITE_ROW);
}

if(hresult != SQLITE_DONE) {
Expand Down
2 changes: 1 addition & 1 deletion tests/exceptions.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ int main() {
// inserting again to produce error
db << "INSERT INTO person (id,name) VALUES (?,?)" << 1 << "jack";
} catch (sqlite_exception& e) {
cerr << e.what() << endl;
cerr << e.get_code() << ": " << e.what() << endl;
expception_thrown = true;
} catch (...) {
cerr << "Ok, we have our excpetion thrown" << endl;
Expand Down